Developer forum

Hi, 

This bug (13173) is fixed in 1.21.0: https://github.com/dynamicweb/Swift/releases/tag/v1.21.0
The specific fix is here: https://github.com/dynamicweb/Swift/commit/f52eb4ef6f059d4643cdb135d3b16c77d1a990f7

BR,
Merethe Vrå Andersen

I'm still experience this issue after implementing the fix. I've added a console.log statement for _favorites.js and seems var productButton = document.querySelector("#FavoriteBtn_" + productId); returns null, thus making the code not able to update the button classlist.(see image) I'm also running swift 1.19.

Hi Joakim

Did you upgrade or just copying the above change? The above change is above a lot of other changes, so you might not just be able to copy these things down as is.

Do you build the Swift js and css your self or do you use our pre-compiled version?

BR Nicolai

I did not upgrade Swift, so still running 1.19. I'm recompiling using webpack included in the github repo.

I copied the changes.

Hi Joakim

Templates and JS go hand in hand - so you cannot be sure just compying code from changeset will sort things out as there are many other changesets between the versions that can affect the code. The button id is defined in ToggleFavorite template here: https://github.com/dynamicweb/Swift/blob/main/Swift/Files/Templates/Designs/Swift/Components/ToggleFavorite.cshtml#L37

What does your template look like - and what is being rendered on the page with the button? Can you find the button in markup? And what is the ID?

Your productid could contain characters that will not work in this context.