Developer forum

Forum » Development » Wrong handling of giftcards

Wrong handling of giftcards

Anders Ebdrup
Reply

Hi Dynamicweb,

 

We have a rather critical issue with prices on giftcards as the price is handled wrong if the data in the database is inclusive VAT.

In PriceCalculated.CalcPrice() I think that you are missing the part with red:

            If PricesInDbVAT AndAlso Not IgnoreVat Then
                If Base.ChkBoolean(Base.GetGs("/Globalsettings/Ecom/Price/UseSalesTaxGroupRateAsSystemTax")) Then

                    'Find product.vatgroup VAT percent
                    Dim VATCountry As Country = FindVATCountry()
                    Dim VATGroupValue As Double = VatGroupPercent(VATCountry)
                    If Not Double.IsNaN(VATGroupValue) Then
                        PricesInDbVATPercent = VATGroupValue
                    End If

                End If

                RawPrice = RemVAT(PriceRaw.Price, PricesInDbVATPercent)
            Else
                RawPrice = PriceRaw.Price
            End If

 

Otherwise the VAT is deducted from the price even though you do not have VAT on gift cards

 

Best regards, Anders


Replies

 
Nicolai Høeg Pedersen
Reply

Hi Anders

We will check it out - I've send the issue to QA for investigation and possible fix.

BR Nicolai

 
Morten Buhl
Reply

Hi Anders

Verified and registered as TFS-20327. Will be fixed in next hotfix

 
Jakob Westhausen
Reply

Hey Nicolai

We are currently running version 8.8.0.2 which should include the hotfix Morten is referring too, but there is an issues with the VAT calculations and the total price can be less then 0 which seems a bit confusing for the customers. Another issue with the giftcards is the shipping logic which I don't think should be handled in the templates.

BR. Jakob Westhausen 

Screen_Shot_2016-05-27_at_17.25.32.png
 
Nicolai Høeg Pedersen
Reply

Hi Jakob

We will take a look at this.

BR Nicolai

 
Morten Buhl
Reply

Works as intended here. Submit a case with some proper reproduction steps and we'll take a look

/Morten

 

You must be logged in to post in the forum