Developer forum

Forum » Development » Obsolete warnings on 9.4

Obsolete warnings on 9.4

E-mail notifications
Imar Spaanjaars Dynamicweb Employee
Imar Spaanjaars
Reply
Posted on 19/02/2018 20:04:37

Hi there,

I am in the process of upgrading a site to 9.4. I am getting lots of warnings on stuff being obsolete, such as Order.GetOrder and so on. The hint is recommending to use the services in Dynamicweb.Ecommerce.Services. However, many of those are internal:

#Region "Not ready for public access"
    Friend Shared ReadOnly Property Discounts As New DiscountService()
    Friend Shared ReadOnly Property OrderLines As New OrderLineService()
    Friend Shared ReadOnly Property Orders As New OrderService()
    Friend Shared ReadOnly Property ProductCategoryFields As New ProductCategoryFieldService()
    Friend Shared ReadOnly Property SalesDiscounts As New SalesDiscountService()
    Friend Shared ReadOnly Property VariantCombinations As New VariantCombinationService()
    Friend Shared ReadOnly Property VariantGroups As New VariantGroupService()
    Friend Shared ReadOnly Property VariantOptions As New VariantOptionService()
#End Region

 

Were the obsolete warnings added a little too early? I can't currently fix them because of the visibility of the services which leads to a pretty confusing situation.

Thanks,

Imar


Replies

 
Nicolai Pedersen
Posted on 22/02/2018 11:16:33
Reply
This post has been marked as an answer

Yes, warnings seems to be early - or dev team forgot to make these public. I will ask them... The responsible is out on vacation, so a little wait. But simply use the old API calls.

Votes for this answer: 2
 
Gaëtan Di Caro
Posted on 22/02/2018 14:21:13
Reply

On the same subject, I'd like to point out that in 9.4.2, Dynamicweb.Ecommerce.Searching.Query.Run() returns a ProductCollection, which is now marked as deprecated, and there's no comment on how to replace it.

 
Martin Vang
Martin Vang
Posted on 26/02/2018 08:56:34
Reply
This post has been marked as an answer

Hi Gaëtan,

This is not on the same subject, really, so a new post would have been helpful to make it easier for us to see that the question needed an answer. :)

ProductCollection is an basically a ICollection<Product> that ensures uniqueness (maybe).

@Imar: The order repository/service did not mature enough to be changed to public, so I've hidden it until I'm satisfied that it does what we want - this just means that you can use the old methods for now, until I've fixed the known bugs/issues with the new service. I know it might not be the best solution to release obsolete methods that indicate that you should use a non-existing alternative, but removing all these warnings only to add them later, because I found 2 bugs seem to be a bad use of time. Hope you'll agree. :)

Just to make this absolutely clear: We wont (as a general rule) delete/remove obsolete methods until Dynamicweb 10 (release date currently unknown), so for now, it's "just" an inconvinience when you get warnings related to working with orders and orderlines.

BR

Martin

Votes for this answer: 1
 
Imar Spaanjaars Dynamicweb Employee
Imar Spaanjaars
Posted on 26/02/2018 11:06:57
Reply

>> but removing all these warnings only to add them later, because I found 2 bugs seem to be a bad use of time. Hope you'll agree. :)

Absolutely!! Thanks!

 

You must be logged in to post in the forum