Developer forum

Hi Imar

My GPT with code access says this :-).

**********

You’re right: that is far too many Save calls — and the reason it still doesn’t work is that you’re creating a FieldOptionTranslation “in the void” and saving it separately, without letting the option own/manage its translations the way the platform expects. In practice, you should:

• Create (or load) a FieldOption

• Set the name via SetName(languageId, name) (this is the “attach translation to the option” part)

• Set Value (and optional flags)

• Call one save on the option

That’s it.

Below is the pattern we use elsewhere (same idea as the command you pasted, just using the eCommerce services directly). It handles new vs existing, avoids duplicates, and persists translations through SetName + Save.

using System;
using System.Collections.Generic;
using System.Linq;
using Dynamicweb.Core;
using Dynamicweb.Ecommerce.Products;

public static class ProductCategoryFieldOptions
{
    public static void UpsertFieldOptions(
        string fieldId,
        IEnumerable<(string Value, string Name)> options,
        bool overwriteExistingNames = false)
    {
        var defaultLanguageId = Dynamicweb.Ecommerce.Services.Languages.GetDefaultLanguageId();

        // Load existing options once
        var existing = Dynamicweb.Ecommerce.Services.FieldOptions
            .GetOptionsByFieldId(fieldId)
            .ToList();

        foreach (var (value, name) in options)
        {
            if (string.IsNullOrWhiteSpace(value))
                continue;

            // Match by Value (usually the safest key); you can also match by Id if you own the Ids
            var opt = existing.FirstOrDefault(x =>
                x.Value.Equals(value, StringComparison.OrdinalIgnoreCase));

            var isNew = opt == null;
            if (isNew)
            {
                opt = new FieldOption { FieldId = fieldId };
            }

            // Prevent duplicates when creating new
            if (isNew && existing.Any(x => x.Value.Equals(value, StringComparison.OrdinalIgnoreCase)))
                continue;

            opt.Value = value;

            // This is the important part: attach translation/name to the option
            // (no separate SaveTranslation needed)
            if (overwriteExistingNames || isNew)
            {
                opt.SetName(defaultLanguageId, name);
            }

            // Optional:
            // opt.IsDefault = ...
            // opt.Image = ...

            Dynamicweb.Ecommerce.Services.FieldOptions.Save(opt);

            if (isNew)
            {
                existing.Add(opt); // keep local list in sync to avoid duplicates in same run
            }
        }
    }

    public static void SetNamesForLanguages(string fieldId, string optionId, IDictionary<string, string> languageIdToName)
    {
        var opt = Dynamicweb.Ecommerce.Services.FieldOptions
            .GetOptionsByFieldId(fieldId)
            .FirstOrDefault(x => string.Equals(x.Id, optionId, StringComparison.OrdinalIgnoreCase));

        if (opt == null) return;

        foreach (var kvp in languageIdToName)
        {
            var languageId = kvp.Key;
            var name = kvp.Value;

            opt.SetName(languageId, name);
        }

        Dynamicweb.Ecommerce.Services.FieldOptions.Save(opt);
    }
}

Why your approach fails (the tiny horror story)

FieldOptionTranslation exists, but saving it independently doesn’t reliably “bind” it to an option unless the option itself is managing the translation collection/state. SetName(languageId, name) is the supported way to associate the translated name with the option — and then Save(option) persists the whole thing in one go. Your code was essentially doing “save a translation object” without guaranteeing it’s linked to the option record in the way the service expects. (doc.dynamicweb.com)

TL;DR

• Don’t call SaveTranslation manually here.

• Don’t call SaveOptions unless you really know what shape it expects (it’s not needed for simple upserts).

• Do: opt.SetName(langId, name); Services.FieldOptions.Save(opt);

If you paste your exact field type (dropdown/radio/etc.) and whether you want to control option IDs (stable IDs across environments) or just let DW generate them, I can tweak the matching strategy (Id vs Value) accordingly—because that detail decides whether your future self will send you angry emails.