Description - The Forms for Editors App is accepting / creating duplicated systemNames, when duplicating fields.
Discovered this when having to mannualy configure a form with 50 custom fields, all with SystemNames previously defined by the customer.
These 50 fields represent 10 equal sets of 5 fields - on wich only SystemNames vary.
In the Code, I declare each "row" of fields, passing an array with the fieldNames to display.
@RenderBlanketOrderProductFields(new string[] {"00Nf400000O1dXq", "00Nf400000O1dYe", "00Nf400000O1dZN", "00Nf400000O1daV", "00Nf400000O1db9", "00Nf400000O1dbn"}, fields)
This way, it will only output the fields in which the SystemName match the given array of system names, that is how i realised this error, otherwise it would pass, and we would be outputting a series of repeated fields, that is not valid for forms.
To ease/fasten the configuration, after the first set was configured, I start to duplicate each set and then change the SystemName accordingly to documentation.
After finishing the full configuration, I notice a lot of gaps (missing form fields) and start to verify if all the system names were set correctly, and start to find (too)many with switched system names in the backend.
Start to correct the wrong ones, and, after each one I correct and save, some other field disappears from the front end. That is when i realize that it was not all "human (my) error" but the fact that the backend seems to be messing with the ID's, in different ways:
- Allowing 2 fields to have the same systemName - this needs to be validated in the backend when saving configurations
- When Changing one of the duplicated system names, the other clone, sometimes(*), changes too. Which means, that even if a person realizes the error, it becomes very tricky to resolve.
- The fact that this happens only sometimes, and the fact that there where so many repeated SystemNames, the first time this error happened to me, gave me the sensation that sometimes, the field saving overlaps - meaning that while saving changes to a field, a previously edited one is still "in memory" or being saved, and their attributes get messed.
Here are 3 videos where I replicate the configuration steps and the error - hope it helps:
-> Step 1 - Duplicate existing set of fields https://www.useloom.com/share/0f9c71fb0ffa49ef9d5c2c3dfc8b395b
-> Step 2 - Reposition these fields by dragging them to the wanted position. https://www.useloom.com/share/b34cd92e2edb4d599385fcbc72311f1c
-> Step 3 - Starting to edit the cloned fields and verify Output:
Part of the fields get the same systemName as the original, when duplicated. Then, when one of the duplicated names is fixed, the "clone" gets the change too (and in this case, due to my code structure, gets invisible). To ease the debug and make the videos comprehensible, the expected systemName is outputted above each input. https://www.useloom.com/share/88f0dce49ad44d76b1e68b65e999b194
So, I have 2 Requests:
- Please validate/prevent repeated SystemNames.
- Would be nice to have an Import (right next to "export") in "Forms for editor"? To avoid manual copy of extensive forms from Dev to Prod environment? - The lack of it was useful to identify this problem, but really increases the time of deployment.
