Developer forum

I've tried just about all the various properties and methods on the Product object and can't seem to find a way to get teh Discount calculations for a product that will return what the Ecom:Product.Discount.Price and Ecom:Product.Price return on the ViewModel

Hi Andrew

There are no discounts on the product objects - so using product and productservice will not help you.

What version are you on? You mention Rapido which could indicate an older version.

You can use this tag @GetTemplateTags("Price") and @GetTemplateTags("Discount") to search for tags containing those 2 strings. If you are in a loop of products you can do @productLoopItem.GetTemplateTags("Price")

That would give you a list of all available tags including the one the price you are looking for.

Some later versions of DW9 contains more tags.

Hi Nicolai,

Apologies, I'm using 9.17.7.
I'm implementing a custom API, so not really using rapido.
Is there a way give an product number to get the discounted value? On the product srevice there is a Product.Discount.Price and a Product.GetDiscountMatrix().

I just need to find out what the product Price after being run through the Discount calcualtions.

Here is what I am doing to loop through the product's variants and each variants prices:
 

                var productService = new ProductService();
                PriceContext priceContext = new PriceContext(Ecommerce.Common.Context.Currency, Ecommerce.Common.Context.Country);

                var product = productService.GetProductById(productId, string.Empty, request.LanguageId);

                if (product == null) return NotFound();

                foreach (var vc in product.VariantCombinations)
                {
                    var vcProduct = vc.GetProduct(Ecommerce.Common.Context.LanguageID);
                    var discounts = vcProduct.GetDiscountMatrix(Ecommerce.Common.Context.Currency.Code);

                }

Hi Andrew

It is not quite that simple. A product has a price and then when you buy it you can get one or more discounts.

I think the easiest way for you to get the products, you can create a list of product viewmodels using the ViewModelFactory - that will take care of calculating the discounts and give you something useful:

IEnumerable<ProductViewModel> products = Dynamicweb.Ecommerce.ProductCatalog.ViewModelFactory.CreateView(ProductViewModelSettings settings, IEnumerable<ProductInfoViewModel> productInfo)

So in your code before creating this list, find the variants you in the end result, and pass them to the above code.

A couple of comments of your code:

>>var productService = new ProductService();
You should not create new instances of services as that can cause some bad behavior - instead use Dynamicweb.Ecommerce.Services.Products which will give you an instance

>>PriceContext priceContext = new PriceContext(Ecommerce.Common.Context.Currency, Ecommerce.Common.Context.Country);
You state custom API - if you are creating a REST api this is not possible as the Common.Context is based on context and REST is state-less. Also if you are not running in the context of a pageview, using Common.Context is also an issue. 

Thanks for the feedback Nicolai.

I was using Dynamicweb.Ecommerce.ProductCatalog.ViewModelFactory.CreateView to create the view model, but the prices that come back are the same for all variants.
I have to get the price collection on the main product which will then give me a list of the variants and the actual prices (before discount).
Regarding getting the discounted price, I'm still at a loss in getting these back.

Hi Andrew

I have asked the partner center to reach out to you.

BR Nicolai

Thanks, appreciated.

Just an update on this:
The issue seems to be that ViewModelFactory.CreateView() and Services.Products.GetProductById() are not applying discounts that use the DiscountExtender.
So the pricing is different between what you can get from TemplateTags (which applies Extended discounts) and what you can get from the DW methods.

Hi Andrew

A product does not calculate discounts ever - so GetProductById() will not do anything related to discounts, nor should it. It will always return the price - before any discounts.

Discounts are applied to an order or orderline. Then the rendering of products will find the price and calculate the potential discount which will be applied if the product is added to the cart and the discount rules are met. Then the rendering  (tag-based or the viewmodel) have properties containing the price, the discount and the price minus the discount in 3 separate properties.

• ProductViewModel
  • PriceBeforeDiscount
  • Discount
  • Price

PriceBeforeDiscount will contain the price coming from the price calculation - can either be the product record price or a price from the matrix.

If the discount of the productviewmodel is not as expected, my guess is that you have a discount where the rules are not yet applicable. E.g. it can be a customer specific discount, a discount related to a voucher code (that sits on the order) - so if you have any of these rules on the discount that are not met, the product viewmodel will not have it. But once you add the product to the cart and the rules are fulfilled, the discount is applied.

Thanks Nicolai.
The discounts are imported from the ERP so let me have a look and seee if there is something specific there that is causing it.

Manged to get this working - the imported discounts were set for a specific shop which wsn't the default.  Going over the code so many times I missed this vital detail.

Thanks for your assitance and patience.

Good find.

I guess that is how it is in IT.... Always the little detail :-).

Glad you found it.