Product numbers with special characters

Didzis Kuzmans

Posted on 22/02/2023 10:51:27

Hello.

I have seen few solutions where we have products with comma, dot, white-space and some other characters in product numbers.

Because of that, there are 2 Swift features which doesn't work:

"Add to favorites list" button and "Add to quote cart" button.

In both templates, product numbers are used in html ID attribute which is used in javascript functions which leads to javascript errors.

I fixed this issue in the way that javascript will work with invalid IDs:

document.querySelector("#"+e)

document.querySelector('[id="'+ e +'"]')

But now i'm thinking that better way would be to fix it in a way that these ID in html won't have any whitespaces or other invalid characters.

Replies

Nicolai Pedersen

Posted on 22/02/2023 11:16:41

Yeah - those kind of IDs are always causing issues. So better clean the IDs as part of the integration.

Imar Spaanjaars

Posted on 10/03/2023 15:53:02

For those looking to fix this themselves, you also need to update the code for the favorite button or otherwise the heart icon won't reflect the latest status. Here's what I changed in _favorites.js:

var clickedButton = e.currentTarget != undefined ? e.currentTarget : document.querySelector('#' + e);
var form = e.currentTarget != undefined ? clickedButton.closest('form') : document.querySelector('#' + e);
...
var productButton = document.querySelector('#FavoriteBtn_' + productId + variantId);

became

var clickedButton = e.currentTarget != undefined ? e.currentTarget : document.querySelector('[id="'+ e +'"]');
var form = e.currentTarget != undefined ? clickedButton.closest('form') : document.querySelector('[id="'+ e +'"]');
...
var productButton = document.querySelector('[id="FavoriteBtn_' + productId + variantId + '"]');

Cheers,

Imar

Didzis Kuzmans

Posted on 17/05/2023 19:03:01

Changing product IDs is not always solution when we are working with existing BC integrations.

And these are frontend javascript errors. We don't actually need product ids in code where we get these javascript errors.

There can be way different identifiers, example, "paragraphxproducty".

In 1.19 I fixed this in html with .Replace(" ","") function in multiple lines without adding any javascript changes.

You must be logged in to post in the forum

Developer forum

Product numbers with special characters

Replies