bg-light in cart templates overrides the theme set on column

Adrian Ursu

Posted on 24/01/2023 15:57:21

Hi guys,

I have noticed in one of our projects that some cart templates have classes that conflict with the theme set on the column.
For example, in eCom7/CartV2/Step/Helpers/StepSummaryUser.cshtml the main div has an explicit class that sets the background color: bg-light

This means that whatever theme I set on the column, this rule will override it. I believe it would be good to avoid this types of hardcoding on the templates if we want to use themes.

I can, of course, remove it from the template myself but in future templates, it will come back. and Customizing templates for this change means customizing all parent templates.

I can't say yet if there are any other helpers with the same issue.

Thank you,
Adrian

Replies

Adrian Ursu

Posted on 24/01/2023 16:07:56

Apparently, there are more templates in this situation:

OrderDeliveryDate.cshtml
StepSummaryDeliveryDate.cshtml
StepSummaryDeliveryMethod.cshtml
StepSummaryOrderDelivery.cshtml
StepSummaryOrderReference.cshtml
StepSummaryPaymentMethod.cshtml
StepSummaryOrderCustomer.cshtml

I hope it helps.
Adrian

Stefan Winther

Posted on 26/01/2023 11:24:36

Hi Adrian,

In the coming release where Parcel shops funcionality will be included - quite a few changes in checkout templates / helpers was made. Among these changes are removal of hard coded bootstrap classes :)

Also some minor nifty things added to our theme-concept to accomodate this.

/Stefan

Adrian Ursu

Posted on 26/01/2023 11:42:41

Hi Stefan,

Sounds very good. Looking forward to see the changes.

Thank you,
Adrian

You must be logged in to post in the forum

Developer forum

bg-light in cart templates overrides the theme set on column

Replies