Hi DW,
We're experience an issue with EcommerceBadge when upgrading past swift v1.15 on solutions where the product field Campaign doesn't already exist.
We've used the deployment tool with the Swift for target -> eCommerce -> EcomProducts_Schema. But it doesn't create the Campaign field.
There's a missing null check on the availableCampaignsObject on line 95/96 (there's a linebreak in the cast).
So I've moved an existing null check further up and moved the other logic inside the if statement in our version (I've added the new version as a txt aswell)
here's a look at the PR change:
(ignore DevOps weird placement of the last added curlybrace...)
Hope you can add it for the next versions, without it our product list looks like this :D
Best regards,
Mikkel Hammer
Developer forum
E-mail notifications
Missing nullcheck in EcommerceBadge.cshtml after Swift v.1.15
Mikkel Hammer
Posted on 07/12/2022 12:57:32
Replies
Stefan Winther
Posted on 16/12/2022 09:02:53
Hi Mikkel,
Great catch - we'll see to that it gets fixed asap :)
Br
/Stefan
Merethe Vrå Andersen
Posted on 19/12/2022 13:08:43
This post has been marked as an answer
Hi,
Fix is now at Github.
BR,
Merethe
Votes for this answer: 1
Mikkel Hammer
Posted on 19/12/2022 13:10:22
Hi both,
Thanks for the fix and letting me know! :)
Best regards,
Mikkel Hammer
You must be logged in to post in the forum