Developer forum

Forum » Development » Custom list control inheriting ListEditor not working after 9.10 Dynamicweb upgrade

Custom list control inheriting ListEditor not working after 9.10 Dynamicweb upgrade

Emil Dumitrescu
Reply

Hello,

We developed a custom control that inherited the ListEditor<T> and worked fine, until 9.10 when the method RenderList has been marked as internal:

internal virtual void RenderList(TextWriter output, T selectedItem)
{
    throw new NotImplementedException();
}

This means that we can no longer override it since it's internal, while the custom control it's defined in an external assembly. While all Dynamicweb's controls that inherit this list work fine (DropDownListEditor<T>, CheckboxListEditor<T> etc.) since they are defined in the same assembly, custom controls won't work anymore after this change, and we receive the NotImplementedException.

Is there any alternative way to make this work again?

Regards,
Emil


Replies

 
Nicolai Pedersen
Reply

Hi Emil

I can see that change - and I do not know why it was made. It was part of a changeset that removed httpcontext from that editor... So a developer hickup I am affraid.

I just changed it back to being protected so it can be reached and overriiden from classes that inherits. Will be out with the next 9.10, 9.12 and 9.13 packages of Dynamicweb.dll

 
Emil Dumitrescu
Reply

Great, thank you Nicolai!

Regards,

Emil

 
Adrian Ursu Dynamicweb Employee
Adrian Ursu
Reply

Hi Nicolai,

Any plans on releasing this fix?

We have 4 solutions that we cannot upgrade without it.

A "pirate" DLL for DW 9.12 would be enough for the moment.

Thank you,
Adrian

 
Nicolai Pedersen
Reply

Was released today.

 
Adrian Ursu Dynamicweb Employee
Adrian Ursu
Reply

Hi Nicolai,

Thank you very much for this very good news.

Adrian

 

You must be logged in to post in the forum