Developer forum

Forum » Development » Methods marked obsolete when replacement not yet available

Methods marked obsolete when replacement not yet available

Hans Kloppenborg
Reply

Hi,

We where cleaning up the warnings on an existing solution after a core update, but found out that again methods have been deemed obsolete while the replacement methods are not yet available. And somewhat annoyingly the documentation has been updated also to this version what is not yet live.

In this case it was "OrderService.CreateOrderLine(Order, Product, double, StockUnit, PriceInfo)' is obsolete: 'Use 'Ecommerce.Services.OrderLines.Create' instead". 

The current "Latest stable" version of Dynamicweb.Ecommerce is 1.6.54 , the new method seems to be available in version 1.7 

Would it be possible to make methods obsolete after the replacement has gone live in the future, so we do not have to spend our time figuring this out, and worse, possible forgetting to replace it when it is finally available?

For instance the discussion about the ProductCategoryFieldService more as a year ago (https://doc.dynamicweb.com/forum/development/development/obsolete-warnings-on-9-4 ) was about a similar issue and those obsolete messages are still not solved with a working ProductCategoryFieldService.

Greets Hans


Replies

 
Shiwanka Chathuranga Dynamicweb Employee
Shiwanka Chathuranga
Reply

I have the same concern 

still too early to mark obsolete as new functions not yet available, code looks ugly with these highlights

image attached

Screen_Shot_2019-07-31_at_09.24.00.png
 
Nicolai Pedersen
Reply
This post has been marked as an answer

Hi Both

Yes - we have discussed this and agreed to not mark methods as obsolete before they actually are...

sorry about the confusion.

BR Nicolai

Votes for this answer: 1
 
Peter Leleulya
Peter Leleulya
Reply

This is a post from almost a year ago .... and I still get the obsolete warning ... and still can't find the suggested "ProductCategoryFieldService.GetCategoryValue" method  ...
 

[ObsoleteAttribute("Use 'ProductCategoryFieldService.GetCategoryValue' instead")]
public Object GetCategoryValue(
	string categoryId,
	string fieldId
)
 
Lars Hejgaard Sørensen Dynamicweb Employee
Lars Hejgaard Sørensen
Reply

Same here. Another year has passed.

 

You must be logged in to post in the forum