Product.Clone() suddenly returning error

Jonas Mersholm

Posted on 10/06/2015 09:17:36

Hi. We have a system where we take products from the main-cart, and clone them to dealer groups. This has worked fine so far, but until after an update to 8.6, we are now receiving the following error:

Type 'Dynamicweb.eCommerce.Products.ProductVatGroupCollection' in Assembly 'Dynamicweb, Version=8.0.0.0, Culture=neutral, PublicKeyToken=null' is not marked as serializable.

This is the code:

            try
            {
                Dynamicweb.eCommerce.Products.Product NP = E.Clone();
            } catch(Exception realExc2)
            {
                HttpContext.Current.Response.Write(realExc2.Message);
            }

As said, this has all worked fine before the upgrade to 8.6.

Any ideas?

Best regards.

Jonas

Replies

Nicolai Høeg Pedersen

Posted on 12/06/2015 10:33:18

Hi Jonas

This is due to TFS#14588, set a vat group for each country on the products. That have added the ProductVatGroupCollection property on the product and that is not serializable.

Instead of doing a clone (not recommended by the way), you could do something like this:

Dynamicweb.eCommerce.Products.Product NP = Product.GetProductByID(e.ID, e.VariantID, e.LanguageID);

Jonas Mersholm

Posted on 12/06/2015 10:50:07

Hi Nicolai.

Will the GetProductById return a new instance of the product, which i can save seperately from the old one? I was recommended to use the clone method half a year ago, because the "Copy" method dident work as expected ( All the product group relations were duplicated etc. etc )

Thanks in advance.

Nicolai Høeg Pedersen

Posted on 12/06/2015 11:24:17

Hi Jonas

Copy gives you the same object instance but with a new record id (autoid), using GetProductById will give you a new instance of the same product.

BR Nicolai

Jonas Mersholm

Posted on 12/06/2015 12:55:55

Aight. I should be using copy then. I need to save the copied product with a new ID :)

Best.

Jonas

Nicolai Høeg Pedersen

Posted on 12/06/2015 14:30:19

Hi Jonas.

Yes, but when using copy the way it is implemented, your original and your copy will have the same object reference... So to avoid issues, do something like this:

copyProduct = e.copy();

Dynamicweb.eCommerce.Products.Product NP = Product.GetProductByID(copyProduct.ID, copyProduct.VariantID, copyProduct.LanguageID);

You must be logged in to post in the forum

Developer forum

Product.Clone() suddenly returning error

Replies